[ 
https://issues.apache.org/jira/browse/HIVE-1378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12910900#action_12910900
 ] 

HBase Review Board commented on HIVE-1378:
------------------------------------------

Message from: "Ning Zhang" <n.nin...@gmail.com>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/828/#review1269
-----------------------------------------------------------


Looks good in general. Some minor comments. I'll also ask Zheng to review it. 


trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
<http://review.cloudera.org/r/828/#comment4317>

    Can you also add this parameter to conf/hive-default.xml? This file should 
contain all user-tunable parameters in HiveConf.java.



trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveBaseResultSet.java
<http://review.cloudera.org/r/828/#comment4318>

    should null be checked first?



trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveBaseResultSet.java
<http://review.cloudera.org/r/828/#comment4319>

    check null first?


- Ning





> Return value for map, array, and struct needs to return a string 
> -----------------------------------------------------------------
>
>                 Key: HIVE-1378
>                 URL: https://issues.apache.org/jira/browse/HIVE-1378
>             Project: Hadoop Hive
>          Issue Type: Improvement
>          Components: Drivers
>            Reporter: Jerome Boulon
>            Assignee: Steven Wong
>             Fix For: 0.7.0
>
>         Attachments: HIVE-1378.1.patch, HIVE-1378.patch
>
>
> In order to be able to select/display any data from JDBC Hive driver, return 
> value for map, array, and struct needs to return a string

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to