[ 
https://issues.apache.org/jira/browse/HIVE-1364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12914162#action_12914162
 ] 

HBase Review Board commented on HIVE-1364:
------------------------------------------

Message from: "Carl Steinbach" <c...@cloudera.com>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/895/
-----------------------------------------------------------

Review request for Hive Developers and John Sichi.


Summary
-------

The patch increases the length of various properties in the Metastore OR 
mapping. Properties which are currently indexed, or which we may want to index 
in the future were increased to a length of 767 bytes. Properties which are not 
indexed and which we are unlikely to ever want to index were increased to a max 
length of 4000 bytes. I also removed the PK constraint on the COLUMNS.TYPE_NAME 
field.


This addresses bug HIVE-1364.
    http://issues.apache.org/jira/browse/HIVE-1364


Diffs
-----

  metastore/src/model/package.jdo 527f4b2 

Diff: http://review.cloudera.org/r/895/diff


Testing
-------


Thanks,

Carl




> Increase the maximum length of SERDEPROPERTIES values (currently 767 
> characters)
> --------------------------------------------------------------------------------
>
>                 Key: HIVE-1364
>                 URL: https://issues.apache.org/jira/browse/HIVE-1364
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Metastore
>    Affects Versions: 0.5.0
>            Reporter: Carl Steinbach
>            Assignee: Carl Steinbach
>             Fix For: 0.6.0, 0.7.0
>
>         Attachments: HIVE-1364.2.patch.txt, 
> HIVE-1364.3.backport-060.patch.txt, HIVE-1364.3.patch.txt, HIVE-1364.patch
>
>
> The value component of a SERDEPROPERTIES key/value pair is currently limited
> to a maximum length of 767 characters. I believe that the motivation for 
> limiting the length to 
> 767 characters is that this value is the maximum allowed length of an index in
> a MySQL database running on the InnoDB engine: 
> http://bugs.mysql.com/bug.php?id=13315
> * The Metastore OR mapping currently limits many fields (including 
> SERDEPROPERTIES.PARAM_VALUE) to a maximum length of 767 characters despite 
> the fact that these fields are not indexed.
> * The maximum length of a VARCHAR value in MySQL 5.0.3 and later is 65,535.
> * We can expect many users to hit the 767 character limit on 
> SERDEPROPERTIES.PARAM_VALUE when using the hbase.columns.mapping 
> serdeproperty to map a table that has many columns.
> I propose increasing the maximum allowed length of 
> SERDEPROPERTIES.PARAM_VALUE to 8192.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to