[
https://issues.apache.org/jira/browse/HIVE-1530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12914419#action_12914419
]
HBase Review Board commented on HIVE-1530:
------------------------------------------
Message from: "Carl Steinbach" <c...@cloudera.com>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/902/
-----------------------------------------------------------
Review request for Hive Developers.
Summary
-------
HIVE-1530.1.patch.txt:
* Move conf/hive-default.xml to common/resources/hive-default.xml and modify
the build so that this gets included in hive-common-xxx.jar
* Copy contents of conf/hive-default.xml to conf/hive-site.xml.template
* Modify HiveConf so that it logs an INFO level message with the location of
the hive-default.xml and hive-site.xml files which were loaded.
This addresses bug HIVE-1530.
http://issues.apache.org/jira/browse/HIVE-1530
Diffs
-----
build.xml 4b345b5
common/build.xml d9ac07e
common/resources/hive-default.xml PRE-CREATION
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 47b7518
conf/hive-default.xml 1465317
conf/hive-site.xml.template PRE-CREATION
Diff: http://review.cloudera.org/r/902/diff
Testing
-------
Thanks,
Carl
> Include hive-default.xml and hive-log4j.properties in hive-common JAR
> ---------------------------------------------------------------------
>
> Key: HIVE-1530
> URL: https://issues.apache.org/jira/browse/HIVE-1530
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Configuration
> Reporter: Carl Steinbach
> Assignee: Carl Steinbach
> Fix For: 0.7.0
>
> Attachments: HIVE-1530.1.patch.txt
>
>
> hive-common-*.jar should include hive-default.xml and hive-log4j.properties,
> and similarly hive-exec-*.jar should include hive-exec-log4j.properties. The
> hive-default.xml file that currently sits in the conf/ directory should be
> removed.
> Motivations for this change:
> * We explicitly tell users that they should never modify hive-default.xml yet
> give them the opportunity to do so by placing the file in the conf dir.
> * Many users are familiar with the Hadoop configuration mechanism that does
> not require *-default.xml files to be present in the HADOOP_CONF_DIR, and
> assume that the same is true for HIVE_CONF_DIR.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
