[ http://issues.apache.org/jira/browse/HIVEMIND-98?page=comments#action_60321 ] James Carman commented on HIVEMIND-98: --------------------------------------
I would agree that it is not very intuitive. I had to dig through the code to figure out WHY we called a method named addElement()! It's because, the object that's pushed onto the stack at the beginning is a org.apache.hivemind.impl.SchemaProcessorImpl object (it actually pushes itself onto the stack). Since we're given the contributions in the form of a java.util.List object, I thought we should just be calling the add() method (from the java.util.List interface). This is definitely one place in the framework where we could use a bit of improvement to make it more intuitive. > Processing Rules docs (and maybe framework) enhanchement request > ---------------------------------------------------------------- > > Key: HIVEMIND-98 > URL: http://issues.apache.org/jira/browse/HIVEMIND-98 > Project: HiveMind > Type: Improvement > Components: framework, documentation > Versions: 1.0 > Environment: (not relevant) > Reporter: Giorgio Gallo > > I just spent one full day to figure out why my configuration points always > ended up empty: the reason is I missed the red box telling me i had to > include the > <invoke-parent method="addElement"/> > rule. > (After smashing my head with a huge hammer for I once again I underestimated > the importance of reading documentation) I realized the red box isn't > actually very visible in docs and I overlooked it because, having a bit of > familiarity with digester, I quit reading after the first few paragraphs. :) > -- > Documentation enhanchement request: > (Since I know I am stupid, but I also think other people are just like me) > Could you move the box to the very top of the file? > -- > Framework enhanchement request (maybe already ok in 1.1 - sorry: didn't > check): > Since this <invoke-parent method="addElement"/> is SO important, why not > adding a new type of rule, say: <add-element/>? After all I (as a HM user) > really don't want to know the name of the method called... > Also, couldn't the rule <set-parent .../> be sort of dangerous if called like > in: > <create-object .../> > <set-parent .../> > ? > I would end up having a reference to whatever HM puts at the bottom of the > stack in an object of mine... > Thank you in advance - and thank you for this beautiful hivemind thing! > Rgds, > Giorgio -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - If you want more information on JIRA, or have a bug to report see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
