[ http://issues.apache.org/jira/browse/HIVEMIND-124?page=comments#action_65760 ] Richard Hensley commented on HIVEMIND-124: ------------------------------------------
After doing all this analaysis, I would suggest that maybe the SmartTranslator be a special case for the BuilderPropertyFacet. The the SmartTranslator is the default translator and is expected to fail, however none of the other translators are expected to fail. What if we eat the exception when the translator is the SmartTranslator, but let it bubble up when the translator is not the SmartTranslator. I know about disliking special cases, but it seem's like a whole lot of work for not very much gain to push the operation of isAssignableFromType() out to everything that can be touched by the BuilderPropertyFacet. I will attach a patch that implements what I'm referring to. > Report a proper message when a constructor argument in BuilderFactory is > invalid > -------------------------------------------------------------------------------- > > Key: HIVEMIND-124 > URL: http://issues.apache.org/jira/browse/HIVEMIND-124 > Project: HiveMind > Type: Bug > Components: framework > Reporter: Richard Hensley > Attachments: patch.txt > > My situation is that I use constructor arguments for all my required > parameters of objects. The code inside of the BuilderFactoryLogic uses the > BuilderPropertyFactet.isAssignableFrom() method to figure out if a particular > parameter in a constructor is right. The > BuilderPropertyFactet.isAssignableFrom() eats an ApplicationRuntimeException > and returns false. This is bad when you miss-spell a service name, for > instance: > <service>service:MyServic</service> > When you meant, > <service>service:MyService</service> > The error that Hivemind throws is that it had trouble finding a valid > constructor, when the real problem was that it had problems finding your > service to even check if the constructor was valid. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
