So, could you apply the special case SmartTranslator patch I sent in?
-----Original Message-----
From: Knut Wannheden (JIRA) [mailto:[EMAIL PROTECTED]
Sent: Thursday, May 19, 2005 11:42 PM
To: Hensley, Richard
Subject: [jira] Commented: (HIVEMIND-124) Report a proper message when a
constructor argument in BuilderFactory is invalid
[
http://issues.apache.org/jira/browse/HIVEMIND-124?page=comments#action_65824
]
Knut Wannheden commented on HIVEMIND-124:
-----------------------------------------
Whoops, seems like I didn't quite remember all of this. Thanks for
refreshing my memory :-)
I agree with you, adding isAssignableToType() to Translator (and then also
ObjectProvider) is not a good idea. It gets too hairy.
As an alternative to a special treatment of SmartTranslator (using
instanceof) we could plainly let the BuilderPropertyFacet log the error it
catches before returning false. Then you should at least see what's going
on if you wade through the logs...
> Report a proper message when a constructor argument in BuilderFactory is
invalid
>
----------------------------------------------------------------------------
----
>
> Key: HIVEMIND-124
> URL: http://issues.apache.org/jira/browse/HIVEMIND-124
> Project: HiveMind
> Type: Bug
> Components: framework
> Reporter: Richard Hensley
> Attachments: patch.txt, patch_with_smarttranslator_specialcase.txt
>
> My situation is that I use constructor arguments for all my required
parameters of objects. The code inside of the BuilderFactoryLogic uses the
BuilderPropertyFactet.isAssignableFrom() method to figure out if a
particular parameter in a constructor is right. The
BuilderPropertyFactet.isAssignableFrom() eats an ApplicationRuntimeException
and returns false. This is bad when you miss-spell a service name, for
instance:
> <service>service:MyServic</service>
> When you meant,
> <service>service:MyService</service>
> The error that Hivemind throws is that it had trouble finding a valid
constructor, when the real problem was that it had problems finding your
service to even check if the constructor was valid.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
