Branch: refs/heads/master
  Home:   https://github.com/STEllAR-GROUP/hpx
  Commit: be54569b4bcb00b9334922e53005a6c1d248197c
      
https://github.com/STEllAR-GROUP/hpx/commit/be54569b4bcb00b9334922e53005a6c1d248197c
  Author: Parsa Amini <[email protected]>
  Date:   2025-12-11 (Thu, 11 Dec 2025)

  Changed paths:
    M 
libs/core/compute_local/include/hpx/compute_local/host/numa_binding_allocator.hpp
    M libs/core/topology/src/topology.cpp

  Log Message:
  -----------
  Fix numa_allocator test failure on macOS

The test tests.unit.modules.compute_local.numa_allocator was failing on
macOS due to two issues:

1. topology::get_numa_domain() was throwing an exception when
   hwloc_get_area_memlocation() failed, which is not supported on macOS.
   Fixed by adding macOS to the platforms that return 0 as a fallback
   (similar to FreeBSD).

2. numa_binding_allocator::get_page_numa_domains() was returning an empty
   string on non-Linux platforms, causing the test assertion to fail.
   Fixed by implementing a fallback that returns a string with all zeros,
   assuming a single NUMA domain (which is typical for macOS systems).

This ensures the test passes on macOS while maintaining the existing
behavior on Linux and other platforms.

Signed-off-by: Parsa Amini <[email protected]>


  Commit: 27de967adb87ed6538f891f9a3d7a4b77a2ec01c
      
https://github.com/STEllAR-GROUP/hpx/commit/27de967adb87ed6538f891f9a3d7a4b77a2ec01c
  Author: Hartmut Kaiser <[email protected]>
  Date:   2025-12-15 (Mon, 15 Dec 2025)

  Changed paths:
    M 
libs/core/compute_local/include/hpx/compute_local/host/numa_binding_allocator.hpp
    M libs/core/topology/src/topology.cpp

  Log Message:
  -----------
  Merge pull request #6830 from parsa/fix/macos-numa-allocator-test

Fix numa_allocator test failure on macOS


Compare: 
https://github.com/STEllAR-GROUP/hpx/compare/feed1d5387ed...27de967adb87

To unsubscribe from these emails, change your notification settings at 
https://github.com/STEllAR-GROUP/hpx/settings/notifications
_______________________________________________
hpx-commits mailing list
[email protected]
https://mail.cct.lsu.edu/mailman/listinfo/hpx-commits

Reply via email to