According to Gabriele Bartolini: > Il ven, 2004-01-30 alle 17:59, Gilles Detillieux ha scritto: > > It certainly seems like a bug to me, and your patch seems correct as far > > as I can tell. However, I don't see the need for supporting a dash or > > "noproxy". With your patch, if you set http_proxy to an empty string > > within the URL block, it should do the right thing. What was missing > > before was the code you added to delete the old "proxy" value and set > > the pointer to null when proxyURL's length is 0. > > I found another *bug* in the *configuration* module. I guess it is a > *logical* bug. > > Everytime I specified an empty attribute in a block, the configuration > parameter was discarded, as it returned a value with 0 length. The > interested method was "HtConfiguration::Find(URL *aUrl, const char > *value) const". > > Here is my proposed patch, which now encapsulates an Exists method in > the Configuration class. > > IMHO, if a string parameter is specified (even if empty), this operation > must be considered to be valid; therefore, I changed the method above > (Find) in order to issue an Exists check before finding a value > corresponding to a certain attribute. > > If the requested parameter is present in the dictionary (even though it > may be empty) the associated value is returned anyway. > > Please have a look at the following patch and let me know what you think > guys, so that I can commit the changes and close the bug.
Good job uncovering that one, Gabriele! I don't know all the ins and outs of the Configuration class, but I don't see anything wrong with what you're doing in the patch. At least, nothing jumps up at me as potentially a problem, and it seems a tidier fix than the last one. All I can say is give it a good test, and if it works for you, commit it as a bug fix. -- Gilles R. Detillieux E-mail: <[EMAIL PROTECTED]> Spinal Cord Research Centre WWW: http://www.scrc.umanitoba.ca/ Dept. Physiology, U. of Manitoba Winnipeg, MB R3E 3J7 (Canada) ------------------------------------------------------- The SF.Net email is sponsored by EclipseCon 2004 Premiere Conference on Open Tools Development and Integration See the breadth of Eclipse activity. February 3-5 in Anaheim, CA. http://www.eclipsecon.org/osdn _______________________________________________ ht://Dig Developer mailing list: [EMAIL PROTECTED] List information (subscribe/unsubscribe, etc.) https://lists.sourceforge.net/lists/listinfo/htdig-dev
