At 4:17 PM -0600 11/10/99, Gilles Detillieux wrote:
>Oops, I had meant to CC this to htdig3-dev last week. No wonder no one
>commented on this. :-P Can anyone shed some light on what the proper
>behaviour should be regarding closing connections on errors?
...
> > In 3.1.3 and earlier, Document::RetrieveHTTP() only does a c.close() at
> > the end, before returning Document_ok. If it returns earlier with any
> > other return code, it doesn't do the c.close(). Is this the problem?
> >
> > As for 3.2, I don't understand the new htnet/HtHTTP.cc code enough to
> > tell if there's a problem there or not. The persistent connection stuff
> > complicates things a lot, but it seems there are some error situations
> > that aren't dealt with thoroughly enough.
I think you're right. I can't think of a reason that c.close()
shouldn't be called. After all, if there's an error, then the
connection is either already dead, or should be.
I haven't checked the HtHTTP code for this, but this is a concern.
I'm going to turn in early tonight, but we should get a patch for the
3.1.x tree for this and see if it helps. It seems like we might want
to roll a 3.1.4 release together fairly soon.
Monday, I'll post a TODO for 3.2.0b1, and perhaps 3.1.4 as well.
-Geoff
------------------------------------
To unsubscribe from the htdig3-dev mailing list, send a message to
[EMAIL PROTECTED]
You'll receive a message confirming the unsubscription.
