On Tue, 4 Sep 2001, David Ferrance wrote:
> A couple of months ago I asked if anyone knew of another module or
> perl 1-liner that would help build multi-level nested loop data
> structures in support of <TMPL_LOOP>. Anyway, nothing seemed to come
> of it so I ended up writing one.
>
> I'm trying to decide if this would be useful to anyone and if I should
> put it in CPAN. If it isn't useful to you guys it probably is only
> useful to me. So if you are interested,
I don't think I can really evaluate how useful this might be - I'm too
close to the code that invented the problem you're trying to solve!
> I love constructive criticism. Fire away.
Don't mind if I do.
- Why does set_sort_cols take a number and not a list of column names?
- $grouper->{OUTER} should really be a method call. You don't want to
encourage people messing with your hash keys.
- Do the sort_cols get set in the inner loop too? I can see reasons for
and against...
- Your best docs are in comments just after the POD! Try to get
something that clear up near the SYNOPSIS.
- Empty DESTROY is not needed.
- More docs are needed for add_details and define_total. I don't
understand what either does.
- Your module may misbehave with floating point data - it's using "ne" to
sorted values and "1.0" ne "1".
-sam
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
