On Tue, 2005-12-06 at 09:07 -0500, Michael Becke wrote: > Hi Oleg, > > As always your work on HttpComponents is quite impressive. I'm glad > you've spent so much time making the API consistent, not only does > this make it easier to use, but it should also be easier to maintain. >
Thanks, Mike. Please do keep an eye on what I am doing to make sure I will not drift away too much. > > This problem can be solved by making Header an interface with two impls: > > an immutable public class and a package private instantiated by passing > > a reference to a CharArrayBuffer. I just thought that would be an > > overkill though. Please let me know if you disagree > > Agreed, overkill. > > > * NumUtils#parseUnsignedInt is used instead of standard Integer#parseInt > > to parse integer values in the HTTP messages such as protocol version > > and chunk size. The parseUnsignedInt method produces no intermediate > > garbage whereas the use of Integer#parseInt usually entails creation of > > an intermediate string object > > Garbage reduction is also a worthwhile goal, though the integer > parsing might be taking it a bit far. I think the performance tests > should help decide this one. I intend to run some benchmarks and see how the new components compare to HttpClient 3.0 in terms of performance when running in different JREs with different heap size. If we see no real benefit in reducing garbage to an absolute minimum, I'll revert the code to use Integer#parseInt Oleg --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
