Oleg Kalnichevski wrote:
Ortwin Glück wrote:

Yes, Oleg, that is exactly what I had in mind. I find it a much cleaner design.


Odi, Roland

I refactored the HttpClientConnection and HttpServerConnection interfaces based on your suggestions.

As of now DefaultHttpClientConnection and DefaultHttpServerConnection basically represent a thin wrapper around an aggregation of a HttpDataReceiver, a HttpDataTransmitter, and a network socket with virtually no control logic of what so ever. They are essentially no longer usable without a controller such HttpRequestExecutor. I am still not entirely convinced this is a good thing but probably I should just get used to this new API.

Please review the latest changes in SVN and let me know what you think.

Cheers,

Oleg


Folks,

I just added a new class called HttpService which essentially represents the HttpRequestExector's server-side counterpart. The HttpService handles all the low level details of receiving and processing HTTP requests, as well generating and sending back HTTP responses. The ElementalHttpServer sample app has been updated to leverage the new HttpService processor class.

Please review and let me know what you think

Oleg



Thanks

Odi

Oleg Kalnichevski wrote:

Odi,

Do you think this will make a better interface?

Oleg

interface HttpClientConnection extends HttpConnection {

   ...
void sendRequestHeader(HttpRequest request) throws HttpException, IOException;

void sendRequestEntity(HttpEntityEnclosingRequest request) throws HttpException, IOException;

HttpMutableResponse receiveResponseHeader(HttpParams params) throws HttpException, IOException;

HttpEntity receiveResponseEntity(HttpParams params) throws HttpException, IOException;
    }


interface HttpServerConnection extends HttpConnection {

   ...
HttpMutableRequest receiveRequestHeader(HttpParams params) throws HttpException, IOException;

HttpEntity receiveRequestEntity(HttpParams params) throws HttpException, IOException;

void sendResponseHeader(HttpResponse response) throws HttpException, IOException; void sendResponseEntity(HttpResponse response) throws HttpException, IOException;
    }



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to