[ 
http://issues.apache.org/jira/browse/HTTPCLIENT-582?page=comments#action_12414578
 ] 

Roland Weber commented on HTTPCLIENT-582:
-----------------------------------------

Hi Sebastian,

We can avoid the creation of some temporary objects by changing your patch as 
follows:
- create the ArrayList with appropriate size (SPECS.size(), in case there is no 
DEFAULT)
- create the array for the toArray call with appropriate size (list.size())

Would you mind adding a description to the JavaDocs, for the overview pages?
"Obtains the registered cookie policy names." or something like that.

I'm not sure whether it's worth the trouble to strip the DEFAULT policy from 
the result.
  return (String[]) SPECS.keySet().toArray(new String [SPECS.size()]);
looks so much simpler. And you can check whether the default policy is 
registered.
It should be, but it can be deregistered.

cheers,
  Roland


> Allow access to registered cookie policies
> ------------------------------------------
>
>          Key: HTTPCLIENT-582
>          URL: http://issues.apache.org/jira/browse/HTTPCLIENT-582
>      Project: Jakarta HttpClient
>         Type: Improvement

>   Components: HttpCookie
>     Reporter: Sebb
>      Fix For: 3.1 Alpha 1
>  Attachments: patch.txt
>
> It would be useful for JMeter (and perhaps other applications) to have access 
> to the list of registered Cookie policy names.
> [If this is acceptable, let me know if you want me to provide a patch.]

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to