[ http://issues.apache.org/jira/browse/HTTPCORE-8?page=comments#action_12437223 ] Roland Weber commented on HTTPCORE-8: -------------------------------------
Hi Oleg, no objections from my side. You should remove or fix the class end comment in HttpAsyncClientConnection, though :-) And the @author tag for both interface and implementation. cheers, Roland > refactor HttpClientConnection and HttpProxyConnection > ----------------------------------------------------- > > Key: HTTPCORE-8 > URL: http://issues.apache.org/jira/browse/HTTPCORE-8 > Project: HttpComponents Core > Issue Type: Improvement > Components: HttpCore > Affects Versions: 4.0-alpha2 > Reporter: Roland Weber > Fix For: 4.0-alpha3 > > Attachments: 20060923-httpasync.patch, 20060923-httpcore.patch, > 2k6-08-25-core-conn-1.tar > > > Instead of trying to define a full abstraction for client connections, let's > define only a minimal interface in HttpCore with only those methods actually > needed in the core. In particular, the core does not need to open connections > (since HTTPCORE-11), and it does not care whether a connection is direct or > through a proxy. An abstraction for client connections can be defined in > HttpConn. > (original description:) > As discussed on the mailing list, separating the responsibility for > establishing connections from the connection objects could improve the design > and help with proxy support. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
