[ http://issues.apache.org/jira/browse/HTTPCLIENT-615?page=comments#action_12460650 ] Oleg Kalnichevski commented on HTTPCLIENT-615: ----------------------------------------------
The patch looks good. I am +1 to commit it. I am also not entirely happy with the way HostConfiguration is being used by MultiThreadedHCM as a cache key. For instance, MTHCM currently does not take into consideration that fact that non-tunneled (non-transparent) proxy connections can be equivalently used to interact with any target host. This said, I am reluctant to make any drastic changes until we get something functional first Oleg > Consider making HostConfiguration immutable > ------------------------------------------- > > Key: HTTPCLIENT-615 > URL: http://issues.apache.org/jira/browse/HTTPCLIENT-615 > Project: HttpComponents HttpClient > Issue Type: Improvement > Components: HttpConn > Reporter: Oleg Kalnichevski > Fix For: 4.0 Alpha 1 > > Attachments: 2k6-12-21-hostconfig-1.txt > > > HostConfiguration class should be immutable. This should also allow methods > of this class to be non-synchronized. > Oleg -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
