Duh! Sorry, did not spot that.

BTW, Findbugs complains that it is _unsynchronized_ at lines 474 and
575, which is clearly wrong.

S.
On 21/02/07, Michael Becke (JIRA) <[EMAIL PROTECTED]> wrote:

    [ 
https://issues.apache.org/jira/browse/HTTPCLIENT-638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Becke closed HTTPCLIENT-638.
------------------------------------

   Resolution: Invalid

Hi Sebb,

In these cases 'this' and 'connectionPool' refer to the same object.  It just 
depends if the code is inside the connectionPool (uses this) or inside MTHCM 
(uses connectionPool).

Mike

> MultiThreadedHttpConnectionManager:connectionPool.numConnections synchronised 
using two different objects
> 
---------------------------------------------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-638
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-638
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpClient
>    Affects Versions: 3.1 RC1
>            Reporter: Sebb
>            Priority: Minor
>
> connectionPool.numConnections in MultiThreadedHttpConnectionManager is synchronized 
using two different objects: "this" and connectionPool.
> Is this intended?
> Can it cause problems?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to