Looks OK now to me. Some minor points:
Not sure if the jars need the pom.properties and pom.xml files. It would be useful to include the following key in the Manifest: Implementation-Version: 4.0-ALPHA4-SNAPSHOT Useful if the jar gets renamed (I had lots of fun trying to work out what versions some of the 3rd party jars in JMeter were...). == I've started using the SVN revision id (rNNNNN) in nightly builds of JMeter; this is proving quite useful. Might be worth considering it as an addition to the manifest. The information can be automatically extracted with SVNANT S. On 21/03/07, Oleg Kalnichevski <[EMAIL PROTECTED]> wrote:
On Tue, 2007-03-20 at 22:39 +0000, sebb wrote: > I think the jars should contain the NOTICE and LICENSE files. > Sebastian, Anthony, (and all) Many thanks for your feedback. I added NOTICE and LICENSE to the META-INF directory of all jars and also fixed missing license headers in all java and xml source files. I spent quite some time browsing the ASF SVN repository but failed to find a single APT file with a license header. I suspect these files were never meant to be distributed as a part of a release artifact in the first place. For the time being I just excluded the web site sources from the SRC assembly. The RAT tool now reports 0 unknown licenses for me. I updated the jars and release packages. Please review and let me know what you think. http://people.apache.org/~olegk/httpcore-4.0-alpha4-preview/jars/ http://people.apache.org/~olegk/httpcore-4.0-alpha4-preview/packages/ Oleg > On 20/03/07, Oleg Kalnichevski <[EMAIL PROTECTED]> wrote: > > Folks, > > > > Could you please verify the release artifacts built off the SVN trunk so > > we could eliminate the most obvious problems and reduce the chances of > > having re-tag the release several times > > > > Release notes: > > http://people.apache.org/~olegk/httpcore-4.0-alpha4-preview/RELEASE_NOTES.txt > > > > Jars: > > http://people.apache.org/~olegk/httpcore-4.0-alpha4-preview/jars/ > > > > Packages: > > http://people.apache.org/~olegk/httpcore-4.0-alpha4-preview/packages/ > > > > Site: > > http://people.apache.org/~olegk/httpcore-4.0-alpha4-preview/site/httpcore/ > > > > If I hear no complaints until tomorrow 20:00 GMT, I'll proceed with > > tagging the release and building the final release packages and will > > call a formal release vote on those packages. > > > > I am aware of the problem with Source Xref reports. For some reason > > Maven's site plugin fails to copy those to the stage directory, but > > reports do get generated correctly. > > > > Oleg > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
