Hello Daniel,

you implement an additional class and perform
unnecessary method calls to avoid null checks?
I must be getting old ;-)

The overhead in this particular case is not a
problem, so I would agree to apply the patch if
you provide one. However, I have to insist on
additional comments in your inner class, like:

  return true; // close the stream

In the current code, the line that assigns a
default to "scws" explains itself, or can be
understood by skipping two lines down. In your
suggestion, "return true" carries no meaning.
You have to cross-reference with either the
JavaDocs in the interface or the actual call
to understand what "true" or "false" means.
Prettier code is not always more readable.

cheers,
  Roland

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to