[
https://issues.apache.org/jira/browse/HTTPCLIENT-658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Roland Weber updated HTTPCLIENT-658:
------------------------------------
Priority: Minor (was: Major)
Issue Type: Improvement (was: Bug)
Firstly, this is not a bug. It has been documented several times on the mailing
list and in the bug tracking system that setting the scheme handler in the
HostConfiguration will only work for relative URLs. Bugs are deviations from
intended or documented behavior, not things that work differently from what
somebody expected. This is a feature request, and I'll grant that it is an
improvement.
Secondly, this is not major. As far as I can tell, in HTTPCLIENT-634 John
Kristian provided us with a solution to this problem that does not affect the
default behavior. A previous lack of test coverage is not a good argument for
changing default behavior that late in the release cycle.
Before I agree to this change, I would like to see discussion of two questions:
1) What and how many applications might be affected by this change? Over the
years, we've told a lot of people that it will only work for relative URLs. Has
anyone written an application that _relies_ on this behavior?
2) If we apply this patch, how can an application switch back to the current
behavior? Ignoring a method call by providing a custom HostConfiguration
implementation is easy, but how do you act on a method _not_ being called?
The second question is independent of the first one. Even if we can't think of
any reason for an application to rely on the scheme handler being reset, we
must not change the behavior between RC1 and final unless we can tell people
how to get back to the original one. Respectfully, I am -0 on this change.
cheers,
Roland
> Custom Protocol in HostConfiguration ignored
> --------------------------------------------
>
> Key: HTTPCLIENT-658
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-658
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Components: HttpClient
> Affects Versions: 3.1 RC1
> Reporter: Olaf Sebelin
> Priority: Minor
> Fix For: 3.1 Final
>
> Attachments: patch.txt, patch_TestHostConfiguration.txt
>
>
> If you you do not register a custom Protocol as scheme default handler but
> set it in HostConfiguration, it will be ignored if the URL given to a Method
> instance is absolute.
> HttpClient will then override it by calling hostconfig.setHost(uri).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
