[
https://issues.apache.org/jira/browse/HTTPCLIENT-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12537965
]
Ortwin Glück commented on HTTPCLIENT-699:
-----------------------------------------
So what this patch is trying to do is save on Object instances. I really wonder
what kind of use case creates that many instances of HttpState that this is a
problem :-)
It replaces the use of a CookieIdentityComparator with a static method. That's
the part I disgust. It would be nicer to require CookieIdentityComparator to be
thread-safe (Comparators are stateless almost always, so no big deal) and
provide a static instance.
It tries to do the cookie expiry without iterator. It's a bit fragile like
that, but should work. Just needs proper test coverage.
I can't see any savings in the changes to getCookies().
matchCredentials has been inlined, because the static method has no access to
initialize the non-static field. Could just as well make the method non-static.
> Performance tuning
> ------------------
>
> Key: HTTPCLIENT-699
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-699
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Components: HttpClient
> Affects Versions: 4.0 Alpha 1
> Reporter: Pascal S. de Kloe
> Priority: Minor
> Attachments: HttpState.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
