On Tue, 2007-10-30 at 16:36 -0400, [EMAIL PROTECTED] wrote: > > Oleg, > > You are right. I removed the localAddr using LocalHost. I did the test > and everything is ok. > > As indicated, I create a patch and submit this file to you. > > > > Best Regards, > > Philip She
Philip, I reviewed the patch. Now it seems localAddr parameter is not being at all. This is certainly not desired. Generally speaking, try to minimize unnecessary 'noise' in your patch. The smaller the patch, the easier it is to review and to understand what changes you are trying to make, the higher the chances of the patch getting accepted. Make sure local files do not make it into the patch. Oleg > > Web Services and Infrastructure Software -BSD > Aviva Canada Inc., > 2206 Eglinton Avenue East, Scarborough, On. M1L 4S8 > Tel: 416-2882667 > > > > Ortwin Glück <[EMAIL PROTECTED]> > > 10/30/2007 04:18 AM > Please respond to > "HttpComponents Project" > <[email protected]> > > > > > To > HttpComponents > Project > <[email protected]> > cc > > Subject > Re: Compatible > issue solution of > HttpClient and > IBM WSAD > environment > > > > > > > > > [EMAIL PROTECTED] wrote: > > By the way, I am just joined the team. I donot know how to prepare > the > > changes in the unified diff format. Any doc or instruct? > > If you're using Eclipse: use the Subclipse Plugin for Subversion > support, then checkout the repository from > > http://svn.apache.org/repos/asf/jakarta/httpcomponents/project-trunk > > Then setup the project so that it compiles. > Make your changes to the code. > > Select the project in the Package Explorer, right click and select > Team > > Create Patch. > > > If you are using the command line, just use "svn diff > patch.txt". > > HTH > > Odi > > --------------------------------------------------------------------- > To unsubscribe, e-mail: > [EMAIL PROTECTED] > For additional commands, e-mail: > [EMAIL PROTECTED] > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
