Hi,
A correct fix will require determining the cause of the two-point
snake. A two-point polygon has zero area, so it is unclear what region
of the mask this is outlining. Perhaps the mask has isolated
single-pixel spots of black and white? E.g. if the user set the input
alpha masks with spots like this. Maybe the contour iterator does not
handle this case gracefully.
Andrew
On Wed, Oct 14, 2009 at 6:51 AM, Rogier Wolff
<rew-googlegro...@bitwizard.nl> wrote:
>
>
> Hi Chris,
>
>
> On Wed, Oct 14, 2009 at 12:55:23AM -0700, cspiel wrote:
>> Oh, I just wanted to follow the DRY principle and to heed Roger's
>> concerns about the runtime penalty of an if-clause inside the loop
>> of all snake segments. Nothing fancy, really.
>
> I wasn't concerned about the runtime impications of the if. I simply
> dislike a special case for a situation that should be possible to
> handle in the main loop.
>
> so strcmp is defined to be implemented as:
>
> while (*a && (*a == *b)) {
> a++; b++
> }
> return *a-*b;
>
> No speclial cases, quickly handle end-of-string etc etc. Nice and
> neat.
>
> Similarly, the case of rotating a list that has only one element on
> one of the ends should not need special casing.
>
> I was more concerned with the "neatness" of the code, and the size of
> the code base. If the program grows and grows, it will too quickly
> become unmaintainable.
>
> Roger.
>
> --
> ** r.e.wo...@bitwizard.nl ** http://www.BitWizard.nl/ ** +31-15-2600998 **
> ** Delftechpark 26 2628 XH Delft, The Netherlands. KVK: 27239233 **
> *-- BitWizard writes Linux device drivers for any device you may have! --*
> Q: It doesn't work. A: Look buddy, doesn't work is an ambiguous statement.
> Does it sit on the couch all day? Is it unemployed? Please be specific!
> Define 'it' and what it isn't doing. --------- Adapted from lxrbot FAQ
>
> >
>
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"hugin and other free panoramic software" group.
A list of frequently asked questions is available at:
http://wiki.panotools.org/Hugin_FAQ
To post to this group, send email to hugin-ptx@googlegroups.com
To unsubscribe from this group, send email to
hugin-ptx+unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/hugin-ptx
-~----------~----~----~----~------~----~------~--~---
