On 7 Apr., 16:48, "T. Modes" <[email protected]> wrote: > ... woa ...
> The new version is now the repository. Thanks > ... make_stacks ... > I can't commit this plugin. Panorama.getImage returns a read-only > variable. You can use the return value only for reading values from > the SrcPanoImage. But you are using it for modifying SrcPanoImage. > This may break some (internal) functionality (which depends on this > assumption) and should not be used (or the Python interface needs to > be changed to respect this). Can you propose a way to allow a plugin to access and modify the Images? So far, the plugin receives the Panorama as it's sole parameter. So it has to go via the Panorama to access the images, and getImage() seems to be the way to access them, since it provides access to the actual image data and not merely a copy. The stack information seems to be in the images, not in the Panorama, so getSrcImage doesn't help me. You are of course right in pointing out that the function in C++ is const SrcPanoImage & getImage(std::size_t nr) const Looks like the python interface simply ignores the const - which might be an issue we have overlooked so far. What other function is there to get at the image data, short of removing the image, modifying it and then reinserting it (which seems like a possible alternative, haven't tried it yet)? Somehow we'll have to figure out a way to allow plugins to modify image data, otherwise the plugin interface would be crippled. And while I'm at it, I find the data structures associated with stacks a bit hard to understand. Is there documentation which would help me to understand the implementation better so I can make a better plugin, or could you give me a brief explanation of the relevant classes, members and methods? Kay -- You received this message because you are subscribed to the Google Groups "Hugin and other free panoramic software" group. A list of frequently asked questions is available at: http://wiki.panotools.org/Hugin_FAQ To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/hugin-ptx
