Hi Harry

It seems that I was a bit premature with my patch. The api-min/max
strings from the python scripts are compared to HUGIN_API_VERSION and
this is defined as  "${V_MAJOR}.${V_MINOR}.${V_PATCH}". So in order to
actually work, the api-max would have to be set to 2012.0.0. Obviously,
the same should apply to api-min.

However, I don't like this. In my book, the patch version should not be
api relevant as it should serve for bug fixing, which should not
influence the API.

Therefore, I propose the following:

The current HUGIN_API_VERSION shall be redefined as

#define HUGIN_API_VERSION "${V_MAJOR}.${V_MINOR}"

Unfortunately, this will influence the behavior of the warning message
regarding the possibly changed preferences upon upgrades, too. If this
is not desired, an additional

#define HUGIN_FULL_VERSION "${V_MAJOR}.${V_MINOR}.${V_PATCH}"

could be defined and used instead.

As an alternative,

#define HUGIN_PYTHON_API_VERSION "${V_MAJOR}.${V_MINOR}"

could be used for the python interface checks only.

Of course, at least the second solution is much more invasive and
probably exceeds the amount of changes tolerated for a beta version. It
could be applied to the trunk, though.


I can supply you with patches for all options. I tend towards the
HUGIN_PYTHON_API_VERSION, at least for the current release. What
solution do you prefer?


With kind regards

Stefan Peter
-- 
In theory there is no difference between theory and practice. In
practice there is.

-- 
You received this message because you are subscribed to the Google Groups 
"Hugin and other free panoramic software" group.
A list of frequently asked questions is available at: 
http://wiki.panotools.org/Hugin_FAQ
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to 
[email protected]
For more options, visit this group at http://groups.google.com/group/hugin-ptx

Reply via email to