On Sunday, 28 January 2018 at 1:38:08 -0800, T. Modes wrote: > Am Sonntag, 28. Januar 2018 00:32:28 UTC+1 schrieb Groogle: >> >> On Saturday, 27 January 2018 at 0:03:44 -0800, T. Modes wrote: >>> Hi all, >>> >>> because of a found bug we are releasing release candidate 2 of Hugin >>> 2018.0. >> >> The bug with "in-source builds are not allowed" is still there. > > This is not a bug (and you are the only one constantly complaining).
One is enough.
> It is a design decision and will not change.
I disagree. At the very least, it is a conscious decision to make
Hugin less portable. From memory it was because one part of the
documentation builds differently from the rest, and if it is built in
the source directory, it will fail the second time. The rest of the
documentation builds correctly, so there's clearly a solution. But
you decided "don't do that, then", rather than fix the bug. Before
this, things worked with no problem.
> You can build in the source folder, but not in the root
> folder. Simply create a folder where all the generated files are
> stored.
I thought you might mean directory when you say folder, but clearly
we're not talking about the root directory here.
> In the source dir
> mkdir build
> cd build
> cmake ..
> (as described in INSTALL_cmake)
This is not the way the FreeBSD Ports Collection works. Summarizing
(this is not what you actually do),
cd /usr/ports/graphics/hugin
mkdir -p work/hugin-2018.0.0
cd work/hugin-2018.0.0
tar xvf /usr/ports/distfiles/hugin-2018.0rc2.tar.bz2
cmake
make
This is a design decision. It works for 25,000 ports, and it will not
change for one package that doesn't want to build in its own tree.
I can work around this bug by patching the files. From
/usr/ports/graphics/hugin/files/patch-CMakeLists.txt:
--- CMakeLists.txt~ 2016-01-24 20:16:54.000000000 +1100
+++ CMakeLists.txt 2016-02-29 14:04:08.376365000 +1100
@@ -2,11 +2,6 @@
# require at least cmake 2.8
cmake_minimum_required(VERSION 2.8.12 FATAL_ERROR )
-# prevent in-tree building
-if("${CMAKE_SOURCE_DIR}" STREQUAL "${CMAKE_BINARY_DIR}")
- message(FATAL_ERROR "In-source builds are not allowed.")
-endif()
-
if(COMMAND cmake_policy)
cmake_policy(SET CMP0003 NEW)
endif(COMMAND cmake_policy)
But that's tacky. There are two obvious ways to handle the problem:
1 (preferred): Fix the build issue. If you have lost track of it, I
can dig it out.
2 (tacky): Put a conditional round the commands in CMakeLists.txt to
not make the check when built with FreeBSD.
Greg
--
Sent from my desktop computer.
Finger groog...@gmail.com for PGP public key.
See complete headers for address and phone numbers.
This message is digitally signed. If your Microsoft mail program
reports problems, please read http://lemis.com/broken-MUA
--
A list of frequently asked questions is available at:
http://wiki.panotools.org/Hugin_FAQ
---
You received this message because you are subscribed to the Google Groups
"hugin and other free panoramic software" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to hugin-ptx+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/hugin-ptx/20180129011517.GD9688%40eureka.lemis.com.
For more options, visit https://groups.google.com/d/optout.
signature.asc
Description: PGP signature
