On 23 September 2018 13:48:10 BST, Andreas Metzler wrote:
>
>building libpano with gcc 8 (instead of 7) triggers a couple of new
>warnings that might be interesting:
>
>parser.c: In function 'ReadImageDescription':
>parser.c:1854:38: warning: '%s' directive writing up to 65535 bytes
>into a region of size 256 [-Wformat-overflow=]
>             sprintf( sBuf.destName, "%s", buf );
>                                      ^~   ~~~

It looks harmless to me, but my C isn't good enough to say for sure.

Along with the earlier typos I'm inclined to release the release candidate, 
since it has been waiting so long, then fixes for these can go into the next 
release.

>Also, the following warnings is thrown a couple of times in the
>test-suite:
>Comparing reference images: 2
>reference/tiff_m_cropped0000.tif -> tests/tiff_m_cropped0000.tif
>TIFFReadDirectory: Warning, Sum of Photometric type-related color
>channels and ExtraSamples doesn't match SamplesPerPixel. Defining
>non-color channels as ExtraSamples..

Seems like libtiff didn't like something about the files rather than the tests 
themselves failing.

-- 
Bruno

-- 
A list of frequently asked questions is available at: 
http://wiki.panotools.org/Hugin_FAQ
--- 
You received this message because you are subscribed to the Google Groups 
"hugin and other free panoramic software" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to hugin-ptx+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/hugin-ptx/580AD240-3A56-4FA5-B74D-74F9559B706B%40postle.net.
For more options, visit https://groups.google.com/d/optout.

Reply via email to