Am Samstag, 24. August 2019 15:30:43 UTC+2 schrieb kfj: > > Now I'm back online again, sorry for the delay. > > On 19.08.19 17:34, T. Modes wrote: > > > snip > > > There are still more changes in the patch. > > What additional changes do you mean? I intended the patch to contain >
>From you python_plugins.diff diff --git a/src/hugin_base/panodata/PanoramaOptions.h b/src/hugin_base/panodata/PanoramaOptions.h --- a/src/hugin_base/panodata/PanoramaOptions.h +++ b/src/hugin_base/panodata/PanoramaOptions.h @@ -240,7 +240,7 @@ I don't know what changes do PanoramaOptions.h have to do with the plugins. > > > Also all files are contained twice. > > I don't know what you mean by that, can you explain? > line 1-7 are diff --git a/src/hugin_script_interface/plugins-dev/dual_use.py b/src/hugin_script_interface/plugins-dev/dual_use.py --- a/src/hugin_script_interface/plugins-dev/dual_use.py +++ b/src/hugin_script_interface/plugins-dev/dual_use.py @@ -1,5 +1,3 @@ -#!/usr/bin/env python - then the same lines again at line 456, 929 and 1390 (so the same changes are 4 times in the diff) This apply is several files, I just mention the first one. The shebangs which I > propose to remove from the python plugins are only useful if these > plugins are written to function on the command line of a shell as well, > so that one can simply launch them from a command line by writing > > woa.py ... > > instead of having to issue the more involved > > python woa.py ... > > or > > python3 woa.py ... > > So you remove this convenience function as a shortcut for you... And so you have to know if Hugin is compiled with Python 2 or Python 3. A correct shebang would solve this issue for the user. Thomas -- A list of frequently asked questions is available at: http://wiki.panotools.org/Hugin_FAQ --- You received this message because you are subscribed to the Google Groups "hugin and other free panoramic software" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/hugin-ptx/e0b6bfb5-dfcf-4aab-9c87-6b02c113999e%40googlegroups.com.
