Yes I want this, and even for the upcoming v1.10.0 :)
Brice


Le 02/10/2014 02:59, Jeff Squyres (jsquyres) a écrit :
> Errr... I got the patch slightly wrong.  The one added line should include 
> the ".$HWLOC_RELEASE_VERSION" at the end.  You get the idea...
>
>
> On Oct 1, 2014, at 8:50 PM, Jeff Squyres (jsquyres) <jsquy...@cisco.com> 
> wrote:
>
>> We just changed the version numbering scheme over in OMPI to always be 
>> "a.b.c", even if c==0.  Do we want the same thing in hwloc?
>>
>> Right now, hwloc uses the old OMPI versioning scheme -- it's "a.b.c", except 
>> when c==0, and then the version is "a.b".
>>
>> It's a pretty simple change:
>>
>> diff --git a/config/hwloc_get_version.sh b/config/hwloc_get_version.sh
>> index 45139f4..4a3d201 100755
>> --- a/config/hwloc_get_version.sh
>> +++ b/config/hwloc_get_version.sh
>> @@ -43,12 +43,7 @@ else
>>        p" < "$srcfile"`
>>        eval "$ompi_vers"
>>
>> -        # Only include the release version if it isn't 0
>> -        if test $HWLOC_RELEASE_VERSION -ne 0 ; then
>> -            
>> HWLOC_VERSION="$HWLOC_MAJOR_VERSION.$HWLOC_MINOR_VERSION.$HWLOC_REL
>> -        else
>> -            HWLOC_VERSION="$HWLOC_MAJOR_VERSION.$HWLOC_MINOR_VERSION"
>> -        fi
>> +        HWLOC_VERSION="$HWLOC_MAJOR_VERSION.$HWLOC_MINOR_VERSION"
>>         HWLOC_VERSION="${HWLOC_VERSION}${HWLOC_GREEK_VERSION}"
>>
>>         # If HWLOC_SNAPSHOT=1, then use HWLOC_SNAPSHOT_VERSION
>>
>>
>> -- 
>> Jeff Squyres
>> jsquy...@cisco.com
>> For corporate legal information go to: 
>> http://www.cisco.com/web/about/doing_business/legal/cri/
>>
>> _______________________________________________
>> hwloc-devel mailing list
>> hwloc-de...@open-mpi.org
>> Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/hwloc-devel
>> Searchable archives: 
>> http://www.open-mpi.org/community/lists/hwloc-devel/2014/10/index.php
>

Reply via email to