#2 and #3 are OK About #1, we could rename pkgconfig and pkgdata prefixes into something like hwlocpkgconfig and hwlocpkgdata. I don't think the actual prefix value matters. I'll try that tomorrow.
Brice Le 24/01/2018 à 23:46, Balaji, Pavan a écrit : > Hi Brice, > > Here are the other patches that we are currently maintaining for hwloc. Can > you see if these can be integrated upstream too: > > https://github.com/pmodels/hwloc/commit/44fe0a500e7828bcb2390fbd24656a7a26b450ed > https://github.com/pmodels/hwloc/commit/5b6d776a1226148030dcf4e26bd13fe16cc885f9 > https://github.com/pmodels/hwloc/commit/9bf3ff256511ea4092928438f5718904875e65e1 > > The first one is definitely not usable as-is, since that breaks standalone > builds. But I'm interested in hearing about any better solution that you > might have. > > Thanks, > > -- Pavan > >> On Jan 24, 2018, at 4:43 PM, Brice Goglin <brice.gog...@inria.fr> wrote: >> >> Thanks, I am fixing this for rc2 tomorrow. >> >> Brice >> >> >> >> Le 24/01/2018 à 22:59, Balaji, Pavan a écrit : >>> Folks, >>> >>> I'm seeing these warnings on the mac os when building hwloc-2.0rc1 with >>> clang: >>> >>> ----8<---- >>> CC lstopo-lstopo.o >>> lstopo.c: In function 'usage': >>> lstopo.c:425:7: warning: "CAIRO_HAS_XLIB_SURFACE" is not defined, evaluates >>> to 0 [-Wundef] >>> #elif CAIRO_HAS_XLIB_SURFACE && (defined HWLOC_HAVE_X11_KEYSYM) >>> ^~~~~~~~~~~~~~~~~~~~~~ >>> lstopo.c: In function 'main': >>> lstopo.c:1041:5: warning: "CAIRO_HAS_XLIB_SURFACE" is not defined, >>> evaluates to 0 [-Wundef] >>> #if CAIRO_HAS_XLIB_SURFACE && defined HWLOC_HAVE_X11_KEYSYM >>> ----8<---- >>> >>> ----8<---- >>> % clang --version >>> Apple LLVM version 9.0.0 (clang-900.0.39.2) >>> Target: x86_64-apple-darwin17.4.0 >>> Thread model: posix >>> InstalledDir: >>> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin >>> ----8<---- >>> >>> Thanks, >>> >>> -- Pavan >>> >>> _______________________________________________ >>> hwloc-users mailing list >>> hwloc-users@lists.open-mpi.org >>> https://lists.open-mpi.org/mailman/listinfo/hwloc-users _______________________________________________ hwloc-users mailing list hwloc-users@lists.open-mpi.org https://lists.open-mpi.org/mailman/listinfo/hwloc-users
