onsdag den 9. Juli 2008 21:20:47 skrev Sebastian Moors: > Hi Jakob, > > thanks for your great contributions! > > I've applied your second patch, but i have to say i that i want to delay > your first patch. > > In my opinion a third mode, "live mode" (accessible through the key "L", > is not the optimal solution. It is not very userfriendly to use more > shortcuts for such an important function. > > At the moment i think that playing the selected pattern should be the > default, because this is what new users expect when they use hydrogen > the first time. The big question is: How to change this behaviour ? > > 1. keyboard shortcut ( your patch ) > 2. new button ( maybe above the patternlist? ) > 3. new mode-button (additional to pattern/song-mode) > 4. preferences-option (too unintuitive)
Actually what I have done is a combination of 1. and 4. I agree that the option should be on by default. I guess adding a button to complement the shortcut (i.e. do the same thing, mut easier discoverable) might be worth it. The nice thing about the keyboar shortcut is that it can be used while the loop is playing (i.e. it doesn't stop transport, like bringing up the preferences window does.) Button or not, it would be nice to have visual indication of the change in behaviour. One way would be to change the colour of the Pattern Mode 'led' from blue to green. Another way, to change the color of the pattern name highlight (that is now light gray). Personally I'm in favor of the way the patch works now, plus the addition of one of the two visual indicators. In the 'old' pattern mode, you would hear ONLY the selected pattern. Presently the "playing patterns" list is inherited from the song mode (if you switch modes in the middle of a song). We could have an option (on by default) to clear the "playing patterns" list upon switch to pattern mode, and the "always play selected pattern" option, also on by default. Then the default behaviour would resemble that of the previous version, and someone who opens the preferences window could easily discover and enable the new 'live' mode. Most importantly, I strongly suggest applying the patch as it is now, because it fixes some tricky issues I found with timing, JACK synchronization and pattern mode. (And it works well.) > > > The button above the pattern-list (where the other pattern options are) > is my favourite solution at the moment, may i can make a mockup the next > days to present it here.. This won't introduce a full new mode ( i think > it is too much overhead to create a new mode for just one feature) but > introduce a new option to the pattern mode. It would be nice to hear > what people think about that.. > > Thanks, > Sebastian > > Jakob Lund wrote: > > Hello > > > > These patches introduce some new features in time for the freeze (I > > hope.) > > > > The most important is a fix-up of the pattern mode: Fixed some timing > > problems with jack, and added a "live editing mode", which makes the > > selected pattern always play in pattern mode, similar to what Scott > > proposed. The feature can be turned off / on during playback by pressing > > "L". It's quite neat I think :^) > > > > The other patch is a minor convenience: To rename a pattern, > > double-clicking its name in the song editor, a line-edit will appear > > _inside the pattern list_, instead of in a small dialog window. The > > dialog is still accessible from the right-click menu, should it be > > necessary to add some other property (than the name) to it later on. > > > > Sebastian, I don't know if you've tried to merged the patch I sent in > > earlier; in any case I think there are some lines in the old patch > > (perhaps changes in jack_output.cpp and hydrogen.cpp), that are also in > > the new one. I'm not very big on svn and merging stuff, but I hope you > > can make it without too much hassle... > > > > Cheers > > > > Jakob Lund. > > > > ------------------------------------------------------------------------ ------------------------------------------------------------------------- Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! Studies have shown that voting for your favorite open source project, along with a healthy diet, reduces your potential for chronic lameness and boredom. Vote Now at http://www.sourceforge.net/community/cca08 _______________________________________________ Hydrogen-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/hydrogen-devel
