Gentlemen:

I have a good quick fix for the Pattern Mode / Tempo Change bug. However, it slightly changes H2's behavior in pattern mode. I'm only bringing it up because I actually like it better. (I do intend to come up with a another fix.)

Current Behavaior (Pattern Mode): While playing, if you stop it and then start it back up -- it will try to restart in the same place where you stopped it. (This is also how Song mode works.)

Proposed Behavior (Pattern Mode): While playing, if you stop it and then start it back up -- it will always restart it from the beginning of the pattern. (See attached patch.)

This works for me because my patterns are usually only 4 or 5 beats long... and that's how I'd prefer it work. If some of you are using longer patterns, I'm guessing that you don't want things to change.

Thanks,
Gabriel

diff --git a/libs/hydrogen/src/hydrogen.cpp b/libs/hydrogen/src/hydrogen.cpp
index 6665e95..3307c4c 100644
--- a/libs/hydrogen/src/hydrogen.cpp
+++ b/libs/hydrogen/src/hydrogen.cpp
@@ -1204,7 +1204,7 @@ inline int audioEngine_updateNoteQueue( unsigned nFrames )
                                        bSendPatternChange = true;
                                }
                                if ( m_nPatternStartTick == -1 ) {
-                                       m_nPatternStartTick = tick - (tick % nPatternSize);
+                                       m_nPatternStartTick = tick;
 //                                     _WARNINGLOG( "set Pattern Start Tick to "
 //                                                  + to_string( m_nPatternStartTick ) );
                                } else {
------------------------------------------------------------------------------
_______________________________________________
Hydrogen-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/hydrogen-devel

Reply via email to