[email protected] schrieb: > hiho, > > the current fx return routing is post masterfader. so you get fx output if > your masterfader is in position zero. > imo, the fx_return have to be pre master fader. > > what do you think? > of course i know that we planned to rewrite the fx section in 0.9.5. but i > mean we can do this small post to pre change for the 0.9.4 release. > > Fine, i think this should be done in 0.9.4. This "feature" annoyed me many times... > greetings > > wolke > > Index: libs/hydrogen/src/sampler/sampler.cpp > =================================================================== > --- libs/hydrogen/src/sampler/sampler.cpp (Revision 726) > +++ libs/hydrogen/src/sampler/sampler.cpp (Arbeitskopie) > @@ -464,8 +464,8 @@ > int nBufferPos = nInitialBufferPos; > int nSamplePos = nInitialSamplePos; > for ( int i = 0; i < nAvail_bytes; ++i ) { > - pBuf_L[ nBufferPos ] += pSample_data_L[ > nSamplePos ] * fFXCost_L; > - pBuf_R[ nBufferPos ] += pSample_data_R[ > nSamplePos ] * fFXCost_R; > + pBuf_L[ nBufferPos ] += pSample_data_L[ > nSamplePos ] * fFXCost_L * cost_L; > + pBuf_R[ nBufferPos ] += pSample_data_R[ > nSamplePos ] * fFXCost_R * cost_R; > ++nSamplePos; > ++nBufferPos; > } > @@ -646,8 +646,8 @@ > fVal_R = linear_interpolation( > pSample_data_R[nSamplePos], pSample_data_R[nSamplePos + 1], fDiff ); > } > > - pBuf_L[ nBufferPos ] += fVal_L * fFXCost_L; > - pBuf_R[ nBufferPos ] += fVal_R * fFXCost_R; > + pBuf_L[ nBufferPos ] += fVal_L * fFXCost_L * > cost_L; > + pBuf_R[ nBufferPos ] += fVal_R * fFXCost_R * > cost_R; > fSamplePos += fStep; > ++nBufferPos; > } > > ------------------------------------------------------------------------------ > This SF.net email is sponsored by: > SourcForge Community > SourceForge wants to tell your story. > http://p.sf.net/sfu/sf-spreadtheword > _______________________________________________ > Hydrogen-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/hydrogen-devel >
------------------------------------------------------------------------------ This SF.net email is sponsored by: SourcForge Community SourceForge wants to tell your story. http://p.sf.net/sfu/sf-spreadtheword _______________________________________________ Hydrogen-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/hydrogen-devel
