Gabriel M. Beddingfield wrote:

> Has anyone else been able to reproduce the bug?  Does this patch seem to
> help? Be sure to test first with a debug build.

I can't try to reproduce the bug, as I still don't have the Internet
connection at home. However, I think you can try to do it using low
zombification timeout, like 500 ms or less (which is how Hollunder found
the analogical bug in Calf). Of course, if you set it too low it will
zombify even from minor slowdowns, which I guess is worse than
occasional xrun - but could be nice for some debugging/testing.

>     The string literal get implicitly converted to a QString.
>     This will _always_ call the QString copy constructor.  This is
>     fixed by making the string literal a static QString.

Yeah, that or passing a const char * in those situations (except when
you want the string to be dynamic, no easy solution here.

Memory allocation in realtime threads is known to be problematic (one of
the known-broken things in Calf, too). It is may be caused by locking in
memory allocator, or other factors like length search for a "right
sized" free block.

>   * try_lock() still sometimes took too long,
>     so I killed the QString assignment for the __locker
>     variable.

Good idea.

>   * All logging is disabled.  When the logging thread
>     is actively processing it's data, it locks the queue.
>     Anything in a process() cycle that wants to add
>     something to the logging queue has to wait. (At
>     least... as far as I can tell.  :-))

Despite trylock? I don't understand.

>   * The audioEngine_process() aborts if not in STATE_READY
>     or STATE_PLAYING.  Any other state doesn't make sense.

Good idea, at least in debug version.

Krzysztof



------------------------------------------------------------------------------
OpenSolaris 2009.06 is a cutting edge operating system for enterprises 
looking to deploy the next generation of Solaris that includes the latest 
innovations from Sun and the OpenSource community. Download a copy and 
enjoy capabilities such as Networking, Storage and Virtualization. 
Go to: http://p.sf.net/sfu/opensolaris-get
_______________________________________________
Hydrogen-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/hydrogen-devel

Reply via email to