Hi Joel, yes, while (true) would also be correct.
bye Christoph 2012/9/19 Joel Nelson <[email protected]> > Hi Cristoph, > > Thanks for your quick reply. > > > ... test and compilation works for me > > (g++ 4.6.3). Which compiler version are you using? > > g++ 4.6.2 > > > > https://github.com/cruppstahl/hypertable/tree/v0.9.6/src/cc/ThriftBroker/tests > > Thanks for pointing me to this directory. I actually wasn't using the > source, but > just copied the Makefile and client_test.cc from the Hypertable website > under > code examples. The website test.cc and the one you linked to were > pretty different. > (I see you have changed that now). I wonder if there is some difference > when > CMake is involved too rather than using the example Makefile on the > website? > > > But i'm going to change the VERSION symbol to avoid the conflict. > > Sounds good. > > I have a separate but related question for serialized_test.cc, test_reader > function: Doesn't the addition of VERSION make it so that > raw_results.size() > always > 0? It always includes the version info at least, so will be >= > 5. You > break your read loop via if (reader.eos()) anyway, so is there any > reason to check the raw_results size rather than just using while(true) ? > > I don't think it matters much, but am curious because I ran into this > issue in > my own code when upgraded (from a very old version to 0.9.6.3). > > Thanks > > Joel > > -- > You received this message because you are subscribed to the Google Groups > "Hypertable Development" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/hypertable-dev?hl=en. > > -- You received this message because you are subscribed to the Google Groups "Hypertable Development" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/hypertable-dev?hl=en.
