On Fri, 16 Jun 2023 17:36:16 GMT, Naoto Sato <[email protected]> wrote:
>> Justin Lu has updated the pull request incrementally with three additional >> commits since the last revision: >> >> - Review: Move default test back to RegisteredCharsets.java >> - Review: rename standard charsets test >> - Revert "Remove Default test" >> >> This reverts commit 346cb4c050adb8bd8a3cb942e25a98484703b997. > > test/jdk/java/nio/charset/Charset/IllegalCharsetName.java line 50: > >> 48: assertThrows(IllegalArgumentException.class, >> 49: () -> Charset.forName(null)); >> 50: } > > Missed this one previously. This one is also not `IllegalCharsetName`, so I'd > prefer not to merge this either. I guess when I think of illegal (I group anything that is _wrong_, so I initially included null and "default"). But you are right that it does not throw IllegalCharsetNameException so it should be moved into its own test. Fixed. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/14500#discussion_r1232588591
