On Wed, 12 Feb 2025 19:35:18 GMT, Naoto Sato <[email protected]> wrote:
> Fixing the regression caused by the JDK-8342550 fix. Since the logging
> facility depends on TimeZone class, it should not use the logging facility.
> Replacing the logging with simple System.err.printf() will fix the issue.
lgtm
test/jdk/java/util/TimeZone/ThreeLetterZoneID.java line 52:
> 50: @Test
> 51: public void testExplicitGetTimeZone() throws Exception {
> 52: ProcessTools.executeTestJava("ThreeLetterZoneID",
> "dummy").shouldMatch(WARNING);
Could use `stderrShouldMatch` here and below instead of `shouldMatch`
-------------
Marked as reviewed by jlu (Committer).
PR Review: https://git.openjdk.org/jdk/pull/23597#pullrequestreview-2613347789
PR Review Comment: https://git.openjdk.org/jdk/pull/23597#discussion_r1953484074
