On Tue, 3 Jun 2025 17:46:11 GMT, Justin Lu <[email protected]> wrote:
>> Please review this PR which modifies the
>> test/jdk/java/util/TimeZone/Bug8167143.java "testCompat" case to be
>> repurposed to check the implicit locales for the FALLBACK BreakIterator and
>> Collator providers. (FALLBACK is the primary provider in those cases.) Since
>> the method is corrected, it can be re-added as a test case. This change
>> stems from discussion in https://git.openjdk.org/jdk/pull/25532.
>
> Justin Lu has updated the pull request incrementally with one additional
> commit since the last revision:
>
> review - var rename
Looks good. Thanks for the repurposing the provider
test/jdk/java/util/TimeZone/Bug8167143.java line 239:
> 237: */
> 238: private static void testImplicitFallbackLocales() {
> 239: LocaleProviderAdapter jre =
> LocaleProviderAdapter.forType(Type.FALLBACK);
Nit: maybe `jre` can be renamed too
-------------
PR Review: https://git.openjdk.org/jdk/pull/25621#pullrequestreview-2893474483
PR Review Comment: https://git.openjdk.org/jdk/pull/25621#discussion_r2124509694
