On Mon, 9 Jun 2025 21:48:59 GMT, Phil Race <[email protected]> wrote:
>> This is the implementation of JEP 504 - Remove the Applet API.
>> API changes are
>> - Remove the entire java.applet package
>> - Remove the javax/swing/JApplet class
>> - Remove applet related APIs in java.beans
>> - Update javadoc referring to applets, including one gif image - now changed
>> to an svg image
>> -
>> Other changes are
>> - Remove references to the removed classes
>> - Remove obsolete tests
>> - Update obsolete code comments
>>
>> sun.awt.AppContext is even more obsolete now than it was before, but
>> eliminating uses of that will be is not required,
>> and will be follow-on internal clean up, at a later date, under unrelated
>> bug ids, and likely not completed in the same
>> release as this JEP is integrated.
>>
>> I have extensively tested this - running all the automated tests used by CI
>> tiers 1 to 8.
>
> Phil Race has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8359053
src/java.desktop/share/classes/java/awt/Polygon.java line 163:
> 161: throw new NegativeArraySizeException("npoints < 0");
> 162: }
> 163: // Fix 6343431: compatibility problems if arrays are not
should this comment just be removed entirely?
src/java.desktop/share/classes/java/awt/Toolkit.java line 1353:
> 1351:
> 1352: /**
> 1353: * {@return the {@code EventQueue} for this application}
why is this specification in brackets?
src/java.desktop/share/classes/javax/swing/JComponent.java line 108:
> 106: * whose root is a top-level Swing container.
> 107: * Top-level Swing containers --
> 108: * such as <code>JFrame</code>, <code>JDialog</code> --
"and" instead of comma maybe?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25698#discussion_r2138745729
PR Review Comment: https://git.openjdk.org/jdk/pull/25698#discussion_r2138747196
PR Review Comment: https://git.openjdk.org/jdk/pull/25698#discussion_r2138750561
