On Fri, 13 Jun 2025 19:59:36 GMT, Phil Race <[email protected]> wrote:
>> test/jdk/javax/sound/sampled/Clip/DataPusherThreadCheck.java line 73:
>>
>>> 71:
>>> 72: private static void checkThread(File file) throws Exception {
>>> 73: SoundClip clip = SoundClip.createSoundClip(file);
>>
>> I think we should either support content handlers via the new SoundClip
>> object or remove the existing implementation, as it is currently tied to
>> AudioClip.
>
> was this comment meant to be on some other (test) code ?
It is about content handlers we discussed above and its implementation in
awt/www/content/audio/. If we want to support content handlers then it is not
necessary to change this in the test:
>SoundClip clip = (SoundClip) file.toURL().getContent();
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25698#discussion_r2146024244
