On Thu, 17 Jul 2025 17:58:51 GMT, Justin Lu <[email protected]> wrote:
>> Raffaello Giulietti has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Added comment to COMPAT static field.
>
> src/java.base/share/classes/jdk/internal/math/FloatingDecimal.java line 1769:
>
>> 1767: * fields (> 550 lines).
>> 1768: */
>> 1769: private static BinaryToASCIIConverter
>> getCompatBinaryToASCIIConverter(double d, boolean isCompatibleFormat) {
>
> Can we just remove the `isCompatibleFormat` param and pass true to `buf.dtoa`
> which should always be true as indicated by the method name and its usage?
There are many more changes that I've planned in `FloatingDecimal`, including
this one and the removal of unused methods.
For this PR, however, I just wanted to keep the changes in `FloatingDecimal`
minimal, focused on the replacement with the new algorithm.
But I have no problems with your proposal, if you insist.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26364#discussion_r2214084343
