On Thu, 7 Aug 2025 23:39:23 GMT, Justin Lu <[email protected]> wrote:
>> This PR clarifies the Unicode extension wording in the DecimalFormatSymbols
>> class description to make apparent that the "nu" extension is supported in
>> addition to the "rg" extension. There already exists "nu" commentary in the
>> specification of the Locale accepting method APIs, the main purpose of this
>> change is to clarify the behavior when both extensions are supplied.
>>
>> Note that "may" wording is intentionally used, as symbols are only
>> overridden if the JRE implementation provides support.
>
> Justin Lu has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Updating NumberFormat with cu as well
LGTM. Reviewed the CSR too.
src/java.base/share/classes/java/text/DecimalFormatSymbols.java line 64:
> 62: * <p>The "rg" (region override), "nu" (numbering system), and "cu"
> (currency)
> 63: * {@code Locale} <a
> href="../util/Locale.html#def_locale_extension">Unicode
> 64: * extensions</a> are supported which may override values within the
> symbols.
This can be replaced with `{@link Locale##def_locale_extension Unicode
extensions}`. There are multiple locations for this, and it is obviously out of
this PR's scope, it can be cleaned up with a separate issue.
-------------
Marked as reviewed by naoto (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/26683#pullrequestreview-3101534352
PR Review Comment: https://git.openjdk.org/jdk/pull/26683#discussion_r2263516692
