On Mon, 5 Jan 2026 08:33:32 GMT, Johny Jose <[email protected]> wrote:
> tzdata changes for 2025c
LGTM.
For the JIRA issue, please fix the last paragraph in the problem text:
Commentary now also uses characters from the set -''""•≤ as this
can be useful and should work with current applications. This
also affects data in iso3166.tab and zone1970.tab, which now
contain strings like "Côte d'Ivoire" instead of "Côte d'Ivoire".
which seems to have converted the non-ASCII quotes to ASCII equivalents, which
made the paragraph not making sense. FWIW, the original was:
Commentary now also uses characters from the set –‘’“”•≤ as this
can be useful and should work with current applications. This
also affects data in iso3166.tab and zone1970.tab, which now
contain strings like “Côte d’Ivoire” instead of “Côte d'Ivoire”
src/java.base/share/data/tzdata/iso3166.tab line 44:
> 42: # “Czech Republic” and “Turkey” rather than “Czechia” and “Türkiye”),
> 43: # and sometimes to omit needless detail or churn (e.g., “Netherlands”
> 44: # rather than “Netherlands (the)” or “Netherlands (Kingdom of the)”).
It's interesting that they started using non-ASCII quotes in comments, which is
different from our policy, but we need to live with it as it is the upstream
change
-------------
Marked as reviewed by naoto (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/29029#pullrequestreview-3627828729
PR Review Comment: https://git.openjdk.org/jdk/pull/29029#discussion_r2662309506
