On Mon, Mar 10, 2008 at 09:02:51AM -0800, David Brownell wrote: > You should #include <linux/gpio.h> now and avoid a lot > of this #ifdeffery ... which is something I think you'd > be told by running checkpatch.pl on 2.6.25-rc5, as well > as most RC4 kernels. Last time I changed my #includes from asm/foo.h to linux/foo.h, it was also wrong :) But now I researched that for irq.h checkpatch.pl had a bug (patch sent), for io.h it is unknown and uncommon to replace it (still recommended according to lkml) and for gpio.h it is probably the right thing to do.
Still, using <linux/gpio.h> does not really avoid the #ifdefs if the priority is to produce less code in the driver. It does avoid them if the priority is simply to remove them (for the price of having an integer and two small blocks of code as unused overhead). May I assume that it getting rid of #ifdefs has priority? > > + /* Use NO_GPIO when this macro is in mainline */ > I hope you mean gpio_is_valid() instead... that's in MM, > but not yet mainline (except when <linux/gpio.h> is all > stubs). Will change the comment. I also realized that I should register/deregister the gpio-pin in the driver; used to have this in the boardsetup, sigh. Will send an updated version later today. All the best, Wolfram -- Dipl.-Ing. Wolfram Sang | http://www.pengutronix.de Pengutronix - Linux Solutions for Science and Industry
signature.asc
Description: Digital signature
_______________________________________________ i2c mailing list i2c@lm-sensors.org http://lists.lm-sensors.org/mailman/listinfo/i2c
