Hi Martin. Thank you for the review and sorry for the late response.
> El 24 ago 2020, a las 16:37, Martin Björklund via Datatracker > <[email protected]> escribió: > > Reviewer: Martin Björklund > Review result: Ready with Nits > > I did an early YANG Doctor's review of this draft. Most of my > comments then have been addressed in this version. > > Comments: > > o As I wrote in my early review, the RFC editor enforces a common > format of YANG modules, so it is better to adhere to this format > before sending the draft to the RFC editor. Use > > pyang -f yang --yang-line-length 69 <FILE> mmm, we already applied the pyang command as you suggest, anyway, we will apply it again for the next version. > > to get a consistent look-and-feel for your module. > > (You will have to manually re-flow description statements after > this.) > > > o There are some leafs that are optional in the model, but w/o a > default value and w/o an explanation of what happens if that leaf > is not set. You should find those and either make them mandatory, > add a default value, or explain what it means when it isn't set. > As an example, > /ipsec-ike/pad/pad-entrypeer-authenticatin/pre-shared/secret > is optional. I suspect that this leaf needs to be mandatory. > Another example is the leaf espencap. You are right. We are reviewing the text. Best regards, Gabi. > > > /martin > > ----------------------------------------------------------- Gabriel López Millán Departamento de Ingeniería de la Información y las Comunicaciones University of Murcia Spain Tel: +34 868888504 Fax: +34 868884151 email: [email protected]
_______________________________________________ I2nsf mailing list [email protected] https://www.ietf.org/mailman/listinfo/i2nsf
