Hi Paul,

On 02/04/2022 14:57, Mr. Jaehoon Paul Jeong wrote:
Hi Alexey,
For your last comment, we can do the following correction along with an appropriate reference.

---------------------------------
=> Apparently the pattern used for pathnames (e.g., '*.exe') is called a glob, not a regular expression.
glob is different from a regular expression.
For example, to get all files with ".exe" type, the pattern is different:

  * regular expression: .*\.exe
  * glob: *.exe
Reference to glob: https://man7.org/linux/man-pages/man7/glob.7.html
I can update the description for leaf-list and added a reference as follows:
          NEW:
          leaf-list exception-files {
            type string;
            description
              "The type or name of the files to be excluded by the
               antivirus. This can be used to keep the known
               harmless files. The value should be interpreted as a
globbing pathname.
               If the value starts with a character '*' (e.g., '*.exe'),
     the antivirus should interpret it as a file pattern/type
               to be excluded.
               If the value does not start with a character '*' (e.g.,
               '/home/example.exe'), the antivirus should interpret it
               as a file name/path to be excluded.";
reference
"GLOB: Linux Programmer's Manual - GLOB";
          }
I have also added the reference for GLOB to the References section in the XML.
---------------------------------

Is it fine with you?

This is better, but a globbing pattern can also start with/contain "?" and "[", and it doesn't have to start with "*". <https://en.wikipedia.org/wiki/Glob_(programming)> (Linux globs are similar.)

If you want to use a single YANG element for both paths and globs, maybe you should say that absolute paths are filenames/paths to be excludes and relative ones are interpreted as globs. This would also work on Windows platforms.

Best Regards,

Alexey


I attach the pdf file of this I-D.

If so, I will submit the revision of this I-D to the IETF repository.

Thanks.

Best Regards,
Paul

On Sat, Apr 2, 2022 at 12:12 AM Alexey Melnikov <[email protected]> wrote:

    Hi Paul,

    On 21/03/2022 12:36, Mr. Jaehoon Paul Jeong wrote:
    Hi Alexey, Jean-Michel, Erik, Martin, Éric, Francesca, Robert,
    Murray, and Zaheduzzaman,
    Here is the revised draft of I2NSF NSF-Facing Interface YANG Data
    Model:
    
https://datatracker.ietf.org/doc/html/draft-ietf-i2nsf-nsf-facing-interface-dm-22

    I attach the revision letter to explain how Patrick and I have
    reflected your comments.
    In the 1st page of the revision letter, there is an index table
    to mark the start page
    of the comments and responses for each reviewer.
    If each of you is satisfied with the revision, please let us know
    and update the status of your stance on this draft.

    You pretty much addressed all of my comments. One of your changes
    has improved existing text, but it is still not quite clear enough:

                  leaf-list exception-files {
                    type string;
                    description
                      "The type or name of the files to be excluded by the
                       antivirus. This can be used to keep the known
                       harmless files.
                       If the value starts with a regular expression (e.g.,
                       '*.exe'), the antivirus should interpret it as a
                       file pattern/type to be excluded.
                       If the value does not start with a dot (e.g.,
                       'example.exe'), the antivirus should interpret it as
                       a file name/path to be excluded.";
                  }
                }

    I think the above raises a question of what is a regular expression? Adding 
a specific reference would help, as there are variety of syntaxes used for 
regular expressions.

    Best Regards,

    Alexey
_______________________________________________
I2nsf mailing list
[email protected]
https://www.ietf.org/mailman/listinfo/i2nsf

Reply via email to