This patch was accepted?
2012/3/26 Michael Stapelberg <[email protected]>
> Hi,
>
> Excerpts from Fernando Lemos's message of 2012-02-24 01:13:04 +0100:
> > This sounds interesting, but have you discussed it with Michael first?
> > I'd recommend always pinging Michael first to see if what you intend
> > to do is in line with the project goals and things like that. Unless,
> > of course, you don't care about getting your patches merged.
> No worries, the patch makes sense (judging from the description).
>
> > Please merge both patches in a single one to make it easier to review
> > (unless they do separate things, of course).
> >
> > I noticed you used "if (" and "if(", please stick with "if (" as
> > that's what the rest of xcb.c uses.
> >
> > You declare and read bar_hidden, but you never seem to write to it. Am
> > I missing something? Also, I'd rather have the code that calls
> > hide/unhide_bar simply not call those functions rather than do the
> > checking inside the functions, but that's subjective, I guess.
> >
> > The indentation level on the call to hide_bars() in the last chunk of
> > the second patch is wrong. Are you sure you don't want that enclosed
> > by brackets, as part of the "else" branch?
> >
> > You're doing all the logic in the drawing code. Perhaps it would be
> > better to detect that stuff directly in the ipc.c, when you receive
> > the workspace info from i3, after the call to parse_workspaces_json.
> All of Fernando’s comments are valid.
>
> Do you want to update the patch? If you need any help/have any questions,
> please let us know.
>
> Best regards,
> Michael
>
