[
http://issues.apache.org/jira/browse/IBATISNET-35?page=comments#action_64606 ]
Ron Grabowski commented on IBATISNET-35:
----------------------------------------
Looks good so far. I noticed that the full .Net type no longer appears in the
log files:
[param0=[5/5/2005 7:27:23 PM,DateTime]
Some people may get confused becuase there are may be multiple classes with the
same name but in different namespaces:
System.Data.DbType.DateTime
System.DateTime
System.Data.DbType.Double;
System.Double;
System.Data.DbType.Decimal;
System.Decimal;
Is that DateTime coming from System.Data.DbType or System? I know the answer
from looking at the source code but someone who is under pressue trying to
track down a bug may not. I'm sure the documentation would explain what is
appearing in the log files but it may be confusing for someone not familiar
with IBatis. I doubt it will ever be a problem but I think its safer to show
the full namespace.
I realize there are fundamental differences between Java and .Net, but I like
the way IBatis for Java does its logging with full namespaces, seperate
Parameters and Types messages, and a unique number that makes it possible to
differentiate between queries:
DEBUG - {pstm-100004} Parameters: [4, audit.login.success, 2004-08-25
09:15:22.809]
DEBUG - {pstm-100004} Types: [java.lang.Integer, java.lang.String,
java.sql.Timestamp]
I think the prefix number will come in handy when the database is executing a
mix of fast/slow queries on a busy server with lots of log messages being
generated.
I know this issue is still a work in progress and that logging might not be the
#1 priority for you right now. Please don't think I'm whining about the logging
code not being exactly how I would like it. I'm just sharing my thoughts :)
> Improve logging of text sent to database and recieved from database to match
> Java version of IBatis
> ---------------------------------------------------------------------------------------------------
>
> Key: IBATISNET-35
> URL: http://issues.apache.org/jira/browse/IBATISNET-35
> Project: iBatis for .NET
> Type: Improvement
> Versions: DataAccess 1.5, DataMapper 1.1
> Environment: Data Mapper - [assembly: AssemblyVersion("1.1.458")]
> Data Access - [assembly: AssemblyVersion("1.5.458")]
> Reporter: Ron Grabowski
> Assignee: Gilles Bayon
> Attachments: SystemDataProxy.zip
>
> Here are some example logs from the Java version of IBatis. The examples show
> INSERT, SELECT, UPDATE, and DELETE statements:
> DEBUG - Checked out connection 30332961 from pool.
> DEBUG - {conn-100003} Connection
> DEBUG - {pstm-100004} PreparedStatement: INSERT INFO UserAudit (UserId,
> AuditEvent, DateOccurred) values (?,?,?)
> DEBUG - {pstm-100004} Parameters: [4, audit.login.success, 2004-08-25
> 09:15:22.809]
> DEBUG - {pstm-100004} Types: [java.lang.Integer, java.lang.String,
> java.sql.Timestamp]
> DEBUG - {pstm-100005} PreparedStatement: SELECT LAST_INSERT_ID() AS id
> DEBUG - {pstm-100005} Parameters: []
> DEBUG - {pstm-100005} Types: []
> DEBUG - {rset-100006} ResultSet
> DEBUG - {rset-100006} Header: [id]
> DEBUG - {rset-100006} Result: [422]
> DEBUG - Returned connection 30332961 to pool.
> DEBUG - Checked out connection 30332961 from pool.
> DEBUG - {conn-100007} Connection
> DEBUG - {pstm-100008} PreparedStatement: SELECT UserId, Login, Password FROM
> User WHERE Login = ? and Password = ?
> DEBUG - {pstm-100008} Parameters: [abc123, def456]
> DEBUG - {pstm-100008} Types: [java.lang.String, java.lang.String]
> DEBUG - {rset-100009} ResultSet
> DEBUG - {rset-100009} Header: [UserId, Login, Password]
> DEBUG - {rset-100009} Result: [4, abc1234, def456]
> DEBUG - Returned connection 30332961 to pool.
> DEBUG - Checked out connection 4548856 from pool.
> DEBUG - {conn-100045} Connection
> DEBUG - {pstm-100046} PreparedStatement: SELECT UserId, Login FROM User
> DEBUG - {pstm-100046} Parameters: []
> DEBUG - {pstm-100046} Types: []
> DEBUG - {rset-100047} ResultSet
> DEBUG - {rset-100047} Header: [UserId, Login]
> DEBUG - {rset-100047} Result: [1, abc123]
> DEBUG - {rset-100047} Result: [4, def456]
> DEBUG - {rset-100047} Result: [6, aaaaa]
> DEBUG - Returned connection 4548856 to pool.
> DEBUG - Checked out connection 7125805 from pool.
> DEBUG - {conn-100043} Connection
> DEBUG - {pstm-100044} PreparedStatement: UPDATE User SET Login = ? WHERE
> UserId = ?
> DEBUG - {pstm-100044} Parameters: [aaaaa, 4]
> DEBUG - {pstm-100044} Types: [java.lang.String, java.lang.Integer]
> DEBUG - Returned connection 7125805 to pool.
> DEBUG - Checked out connection 27062282 from pool.
> DEBUG - {conn-100043} Connection
> DEBUG - {pstm-100044} PreparedStatement: DELETE FROM User WHERE UserId = ?
> DEBUG - {pstm-100044} Parameters: [4]
> DEBUG - {pstm-100044} Types: [java.lang.Integer]
> DEBUG - Returned connection 27062282 to pool.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
