Hi, On Saturday 26 May 2007 13:31, Henrique de Moraes Holschuh wrote: > Register an input device to send input events to userspace. > > This patch is based on a patch by Richard Hughes <[EMAIL PROTECTED]>. > > Signed-off-by: Henrique de Moraes Holschuh <[EMAIL PROTECTED]> > Cc: Richard Hughes <[EMAIL PROTECTED]>
Looks OK, however I am curious why you split registration and generating input events into 2 patches... > --- > drivers/misc/thinkpad_acpi.c | 31 +++++++++++++++++++++++++++++-- > drivers/misc/thinkpad_acpi.h | 3 +++ > 2 files changed, 32 insertions(+), 2 deletions(-) > > diff --git a/drivers/misc/thinkpad_acpi.c b/drivers/misc/thinkpad_acpi.c > index e1c84e3..c0b8155 100644 > --- a/drivers/misc/thinkpad_acpi.c > +++ b/drivers/misc/thinkpad_acpi.c > @@ -487,13 +487,14 @@ static char *next_cmd(char **cmds) > /**************************************************************************** > **************************************************************************** > * > - * Device model: hwmon and platform > + * Device model: input, hwmon and platform > * > **************************************************************************** > > ****************************************************************************/ > > static struct platform_device *tpacpi_pdev = NULL; > static struct class_device *tpacpi_hwmon = NULL; > +static struct input_dev *tpacpi_inputdev = NULL; > Why do you initialize static variables? They are guaranteed to be 0/NULL. -- Dmitry ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ ibm-acpi-devel mailing list ibm-acpi-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
