Hi!
> > > + for (i = 0; i < n; i++)
> > > + t.temp[i] = t.temp[i] / 1000;
> > > +
> > > + /* Fill missing sensors with N/A marker */
> > > + for (i = n; i < TPACPI_MAX_THERMAL_SENSORS; i++)
> > > + t.temp[i] = -128;
> >
> > -273 would be better "N/A" marker :-).
>
> No can do. The firmware uses -128 (it is a signed 8-bit value), so there is
> an internal driver ABI *and* an userspace ABI since 2.6.13 or thereabouts
> that forces N/A sensors in thinkpad-acpi to return -128...
>
> In sysfs, I return an error code instead, which is arguably a much better
> way of doing that.
>
> But I do agree -273 would be a cooler value to return for N/A :-)
:-).
> > > + /* FIXME: it is ugly */
> > > + printk(TPACPI_NOTICE
> > > + "temperatures (Celsius): "
> > > + "%d %d %d %d %d %d %d %d %d %d %d %d %d %d %d %d\n",
> >
> > But this indeed is ugly. Why not sometihng like
> >
> > printk(TPACPI_NOTICE "temperatures (Celsius): ");
> > for (i = 0; i < n; i++)
> > printk(KERN_CONT "%d ", t.temp[i]);
> > printk(KERN_CONT "\n");
> >
> > ...you'd get rid of #ifdef above, ugly -128 markers, and nasty %d series...
>
> Can't get rid of -128, unless I print N/A instead, which your for() loop
> would allow.
>
> However, while using KERN_CONT is nicer, that printk is important and needs
> to get out to the logs with no reordering, no long delay, and preferably, no
> other printks interleaved with it. Please excuse my lack of knowledge on
> this, but wouldn't KERN_CONT make it far more likely that a problem happens
> to the printk that will make it hard to read/useless (if reordering
> happens)?
It should be ok. Reordering is not possible, KERN_CONT will not
introduce delays. Interleaved messages are possible on SMP, but very
very unlikely. I don't really expect problems.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures)
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
------------------------------------------------------------------------------
Join us December 9, 2009 for the Red Hat Virtual Experience,
a free event focused on virtualization and cloud computing.
Attend in-depth sessions from your desk. Your couch. Anywhere.
http://p.sf.net/sfu/redhat-sfdev2dev
_______________________________________________
ibm-acpi-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
