On Tue, 26 Oct 2010, Julia Lawall wrote: > From: Julia Lawall <ju...@diku.dk> > > Delete successive assignments to the same location.
There are often results of mismerges or other assorted screw ups, often done by the maintainer itself (e.g. me in thinkpad-acpi's case) during development. The patch is correct, and I thank you for the head's up. But let me track down what caused it first, hmm? I also highly recommend that this should be done in all cases you find, instead of just blindly fixing the assignment. I suggest using git --blame to track down what added the duplicated assignments, and check if it looks sane... It is often a VERY BAD IDEA to remove such markers of potential brokennes without checking out if they're actually helpfully trying to warn you of worse badness :p But hey, maybe you've already done that. If you did, I apologise for preaching to the choir. -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh ------------------------------------------------------------------------------ Nokia and AT&T present the 2010 Calling All Innovators-North America contest Create new apps & games for the Nokia N8 for consumers in U.S. and Canada $10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store http://p.sf.net/sfu/nokia-dev2dev _______________________________________________ ibm-acpi-devel mailing list ibm-acpi-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
